Feature/416 Added support for multiple call to actions per project. #447

Arilith · 2021-05-28T12:32:29Z

Description

Added support for multiple call to actions per project, with the limits and conditions discussed in #440 .

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

My code follows the style guidelines of this project
I did not update API Controllers, if I did, I added/changed Postman tests
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I updated the changelog with an end-user readable description
I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
These steps will be used during release testing.

Add a single call to action

Add a new project, by posting to "/api/Project".
Make sure you only include one call to action.
Make sure the "optionvalue" of the call to action is correct, look at the "CallToActionOptions" table for possible correct values.
After the request succeeded, you should be able to see the project with the call to action by going to "/api/Project/"

Add Multiple call to actions

Add a new project, by posting to "/api/Project".
Make sure you include multiple call to actions.
Make sure the "optionvalue" of all call to actions is correct, look at the "CallToActionOptions" table for possible correct values. (Preferably pick multiple different values)
After the request succeeded, you should be able to see the project with the call to action by going to "/api/Project/"

Add call to action with invalid action value

Add a new project, by posting to "/api/Project".
Make sure you include at least one call to action.
Make sure the "optionvalue" of all call to actions is incorrect, for example "INCORRECTACTION"
You should receive a bad request (400) error, with an instance-id of "40EE82EB-930F-40C8-AE94-0041F7573FE9"

Add call to action with duplicate action values

Add a new project, by posting to "/api/Project".
Make sure you include at least two call to actions.
Make sure the "optionvalue" of at least two call to actions are the same and correct, for example "Join today"
You should receive a bad request (400) error, with an instance-id of "D2C8416A-9C55-408B-9468-F0E5C635F9B7"

Add more than four call to actions

Add a new project, by posting to "/api/Project".
Make sure you include at least five call to actions.
Make sure the "optionvalue" of all call to actions are DISTINCT and CORRECT for example "Join today", "Provide feedback", "Apply now", "Collaborate with us", "More information"
You should receive a bad request (400) error, with an instance-id of "E780005D-BBEB-423E-BA01-58145D3DBDF5"

Link to issue

Closes: #416

…mits for the amount of CTA's and duplicate CTA's.

RubenFricke

Looks good Tristan! Code looks code, it's amazing how fast you were able to get familiar with the codebase. Good job! I have one small remark (nothing spectacular). I noticed that I'm able to add 2 call to actions with the same option-value while in the create function this is not possible. Could you take a look into this please?

Overall it looks really good, keep up the good work.

Data/06_Data.csproj

API/Controllers/ProjectController.cs

Arilith · 2021-06-01T08:32:19Z

Looks good Tristan! Code looks code, it's amazing how fast you were able to get familiar with the codebase. Good job! I have one small remark (nothing spectacular). I noticed that I'm able to add 2 call to actions with the same option-value while in the create function this is not possible. Could you take a look into this please?

Overall it looks really good, keep up the good work.

I will fix that as soon as possible, thanks for the remark!

…tman tests for this.

niraymak · 2021-06-07T13:48:11Z

Please note that the frontend is not yet ready for this PR to be merged. See comment: DigitalExcellence/dex-frontend#454 (comment)
I guess we should merge both PR's at the same time.

niraymak

Only one minor change requested!

Nice first PR 👍

waltersajtos · 2021-06-17T12:17:31Z

API/Controllers/ProjectController.cs

+                        Instance = "965D9C50-064F-4AFD-8CEB-28E556E47906"
+                    };
+                    return BadRequest(problem);
+                }


Shouldn't this check if there are duplicate OptionValues instead of Values? Option value is the type of call to action (e.g "Join today") and value is the url ("https://github.com/digitalexellence/dex-frontend"). Right now it's not possible to link the same page twice, I don't think that that is the behaviour we want.

Well, as this is the second pull-request for this issue, it may be a little unclear. But in the previous PR #440 it was asked to also check for the values. So currently it's not possible to add any duplicate buttons as that could be unclear and it's not possible to add multiple of the same URL's.

I think people should be able to add the same url on different buttons, maybe @RubenFricke & @niraymak can give their opinion on this?

In my opinion, the URL can be the same in multiple added call to actions. However, you should not be able to add 2 the same call to action (I think I also mentioned this in the other pull request, but I can't remember anything said about checking on the values). @niraymak do you have any opinions about this?

I agree with you. @RubenFricke

Good, I'll update this today.

….com/DigitalExcellence/dex-backend into feature/416-2-multiple-calltoactions

niraymak

Will approve when frontend is ready for it. :)

waltersajtos

Just finished the front-end implementation, everything worked as expected. Good work!

regreg

Added support for multiple call to actions per project. Also added li…

29cc53a

…mits for the amount of CTA's and duplicate CTA's.

Arilith requested review from niraymak and RubenFricke May 28, 2021 12:32

Arilith self-assigned this May 28, 2021

Arilith mentioned this pull request May 28, 2021

Feature/416 multiple calltoactions #440

Closed

13 tasks

Fixed postman tests for alumni-user.

36dfb36

RubenFricke requested changes Jun 1, 2021

View reviewed changes

Data/06_Data.csproj Outdated Show resolved Hide resolved

API/Controllers/ProjectController.cs Outdated Show resolved Hide resolved

Arilith added 2 commits June 4, 2021 12:39

Added check for multiple of the same call to action values. Added pos…

1f635d0

…tman tests for this.

Merge branch 'develop' into feature/416-2-multiple-calltoactions

03a9f25

updated Postman collection after merge

aeb3363

niraymak previously requested changes Jun 9, 2021

View reviewed changes

waltersajtos approved these changes Jun 17, 2021

View reviewed changes

waltersajtos requested changes Jun 17, 2021

View reviewed changes

Arilith added 4 commits June 18, 2021 11:18

Removed Test Itemgroup

f00da66

Disabled double call to action value checks.

783e02a

Merge branch 'feature/416-2-multiple-calltoactions' of https://github…

299307e

….com/DigitalExcellence/dex-backend into feature/416-2-multiple-calltoactions

Changed postman tests to not check for duplicate values anymore.

c65ec49

Arilith requested review from RubenFricke, waltersajtos and niraymak June 21, 2021 10:33

Arilith changed the title ~~Added support for multiple call to actions per project. Also added li…~~ Feature/416 Added support for multiple call to actions per project. Jun 21, 2021

niraymak reviewed Jun 22, 2021

View reviewed changes

merge with develop and fix merge conflicts postman collection

1cdd3c1

waltersajtos approved these changes Jun 23, 2021

View reviewed changes

Merge branch 'develop' into feature/416-2-multiple-calltoactions

b962081

RubenFricke approved these changes Jun 29, 2021

View reviewed changes

RubenFricke merged commit 5f693c1 into develop Jun 29, 2021

RubenFricke deleted the feature/416-2-multiple-calltoactions branch June 29, 2021 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/416 Added support for multiple call to actions per project. #447

Feature/416 Added support for multiple call to actions per project. #447

Arilith commented May 28, 2021 •

edited

Loading

RubenFricke left a comment

Arilith commented Jun 1, 2021

niraymak commented Jun 7, 2021

niraymak left a comment

waltersajtos Jun 17, 2021

Arilith Jun 18, 2021

waltersajtos Jun 18, 2021

RubenFricke Jun 18, 2021

niraymak Jun 18, 2021

Arilith Jun 21, 2021

niraymak left a comment

waltersajtos left a comment

Feature/416 Added support for multiple call to actions per project. #447

Feature/416 Added support for multiple call to actions per project. #447

Conversation

Arilith commented May 28, 2021 • edited Loading

Description

Type of change

Checklist

Steps to Test or Reproduce

Link to issue

RubenFricke left a comment

Choose a reason for hiding this comment

Arilith commented Jun 1, 2021

niraymak commented Jun 7, 2021

niraymak left a comment

Choose a reason for hiding this comment

waltersajtos Jun 17, 2021

Choose a reason for hiding this comment

Arilith Jun 18, 2021

Choose a reason for hiding this comment

waltersajtos Jun 18, 2021

Choose a reason for hiding this comment

RubenFricke Jun 18, 2021

Choose a reason for hiding this comment

niraymak Jun 18, 2021

Choose a reason for hiding this comment

Arilith Jun 21, 2021

Choose a reason for hiding this comment

niraymak left a comment

Choose a reason for hiding this comment

waltersajtos left a comment

Choose a reason for hiding this comment

Arilith commented May 28, 2021 •

edited

Loading